Add quic_disconnect interface #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wanghaEMQ
commented
Apr 27, 2023
•
wanghaEMQ
commented
- Fix the error of calling stack overflow when receiving
- Add quic_disconnect interface
- Add nng_mqtt_quic_client_close interface for user.
- Fix the error that shutdown connection after close
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #542 +/- ##
==========================================
- Coverage 53.23% 53.18% -0.06%
==========================================
Files 120 120
Lines 36573 36575 +2
==========================================
- Hits 19471 19453 -18
- Misses 17102 17122 +20
☔ View full report in Codecov by Sentry. |
JaylinYu
approved these changes
Apr 30, 2023
| if (qstrm->closed == true || qstrm->stream == NULL) | ||
| return -2; | ||
| MsQuic->StreamShutdown( | ||
| qstrm->stream, QUIC_STREAM_SHUTDOWN_FLAG_ABORT, NNG_ECONNSHUT); |
There was a problem hiding this comment.
need to close connection alone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.