Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conn_param leaking issue which discovered by wangha #553

Merged
merged 8 commits into from
May 6, 2023
Merged

Conversation

JaylinYu
Copy link
Member

@JaylinYu JaylinYu commented May 6, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2023

Codecov Report

Patch coverage: 34.14% and project coverage change: -0.01 ⚠️

Comparison is base (2d4479f) 53.19% compared to head (ffa7a8e) 53.18%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #553      +/-   ##
==========================================
- Coverage   53.19%   53.18%   -0.01%     
==========================================
  Files         120      120              
  Lines       36594    36620      +26     
==========================================
+ Hits        19465    19478      +13     
- Misses      17129    17142      +13     
Impacted Files Coverage Δ
src/mqtt/protocol/mqtt/mqttv5_client.c 0.00% <0.00%> (ø)
src/supplemental/mqtt/mqtt_msg.c 47.45% <22.22%> (-0.48%) ⬇️
src/sp/protocol/mqtt/nmq_mqtt.c 45.80% <55.55%> (+0.76%) ⬆️
src/mqtt/protocol/mqtt/mqtt_client.c 66.52% <58.33%> (+0.65%) ⬆️

... and 20 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/supplemental/mqtt/mqtt_msg.c Show resolved Hide resolved
@JaylinYu JaylinYu closed this May 6, 2023
@JaylinYu JaylinYu deleted the jaylin/dev branch May 6, 2023 07:26
@JaylinYu JaylinYu restored the jaylin/dev branch May 6, 2023 07:27
@JaylinYu JaylinYu reopened this May 6, 2023
@JaylinYu JaylinYu merged commit 2aaa84b into main May 6, 2023
11 of 14 checks passed
@JaylinYu JaylinYu deleted the jaylin/dev branch May 6, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants