Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* FIX [nmq_mqtt] pipe reaper needs a bigger lock #1180 of NanoMQ #564

Merged
merged 1 commit into from
May 18, 2023

Conversation

JaylinYu
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.12 ⚠️

Comparison is base (6e40b36) 53.22% compared to head (c675853) 53.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #564      +/-   ##
==========================================
- Coverage   53.22%   53.10%   -0.12%     
==========================================
  Files         120      120              
  Lines       36575    36576       +1     
==========================================
- Hits        19467    19424      -43     
- Misses      17108    17152      +44     
Impacted Files Coverage Δ
src/sp/protocol/mqtt/nmq_mqtt.c 45.80% <100.00%> (ø)

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JaylinYu JaylinYu requested a review from wanghaEMQ May 17, 2023 10:55
@JaylinYu
Copy link
Member Author

This solves nanomq/nanomq#1180, but might dragging down the performance

@JaylinYu JaylinYu merged commit 0f0684d into main May 18, 2023
13 of 16 checks passed
@JaylinYu JaylinYu deleted the jaylin/develop branch May 18, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant