Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQTT v3.1 support #605

Merged
merged 5 commits into from
Jul 6, 2023
Merged

MQTT v3.1 support #605

merged 5 commits into from
Jul 6, 2023

Conversation

OdyWayne
Copy link
Collaborator

@OdyWayne OdyWayne commented Jul 6, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage: 10.00% and project coverage change: -0.07 ⚠️

Comparison is base (e0c37d8) 52.92% compared to head (97e1212) 52.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #605      +/-   ##
==========================================
- Coverage   52.92%   52.86%   -0.07%     
==========================================
  Files         120      120              
  Lines       36733    36740       +7     
==========================================
- Hits        19441    19422      -19     
- Misses      17292    17318      +26     
Impacted Files Coverage Δ
src/sp/transport/mqtt/broker_tcp.c 42.47% <0.00%> (-0.17%) ⬇️
src/sp/protocol/mqtt/mqtt_parser.c 47.94% <16.66%> (-0.32%) ⬇️

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@OdyWayne
Copy link
Collaborator Author

OdyWayne commented Jul 6, 2023

this is a strict version of MQTT 3.1. The specification requires less restrictions on utf-8.

@OdyWayne OdyWayne requested a review from xinyi-xs July 6, 2023 04:21
@JaylinYu JaylinYu merged commit 2b83824 into main Jul 6, 2023
14 of 16 checks passed
@JaylinYu JaylinYu deleted the herman/dev branch July 6, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants