-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit test for rule & codec & disconnect tcp & broker_tcp v5 #628
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work
@@ -481,6 +481,8 @@ NNG_DECL void nng_mqtt_msg_set_unsubscribe_property(nng_msg *, property *); | |||
NNG_DECL void nng_mqtt_msg_set_unsuback_return_codes( | |||
nng_msg *, uint8_t *, uint32_t); | |||
NNG_DECL uint8_t *nng_mqtt_msg_get_unsuback_return_codes(nng_msg *, uint32_t *); | |||
NNG_DECL property *nng_mqtt_msg_get_unsuback_property(nng_msg *); | |||
NNG_DECL void nng_mqtt_msg_set_unsuback_property(nng_msg *, property *); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
@@ -508,7 +509,7 @@ nni_mqtt_msg_set_unsubscribe_topics( | |||
for (size_t i = 0; i < topic_count; i++) { | |||
nni_mqtt_topic_array_set( | |||
proto_data->payload.unsubscribe.topic_arr, i, | |||
(const char *) topics[i].buf); | |||
(const char *) topics[i].buf, topics[i].length); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
previous bug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so. Length is an unused arg in unsub before, now it is fixed and works just like sub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
No description provided.