* FIX [ws] Fix a timing issue #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If recv_cb executes before accept_cb, ep_aio will be empty, and the uaio in recv_cb will not be assigned correctly, which will cause the listener's accaio to fail to finish properly, resulting in a ws link establishment failure problem. Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #676 +/- ##
==========================================
+ Coverage 64.63% 64.85% +0.22%
==========================================
Files 119 119
Lines 35375 35375
==========================================
+ Hits 22864 22944 +80
+ Misses 12511 12431 -80
☔ View full report in Codecov by Sentry. |
|
@Hermann0222 lets make a coverage test on ws |
Roger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If recv_cb executes before accept_cb, ep_aio will be empty, and the uaio in recv_cb will not be assigned correctly, which will cause the listener's accaio to fail to finish properly, resulting in a ws link establishment failure problem.
fixes (nanomq/nanomq#1210)