Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

topic reflection #692

Merged
merged 12 commits into from
Sep 17, 2023
Merged

topic reflection #692

merged 12 commits into from
Sep 17, 2023

Conversation

RanMaoyi
Copy link
Contributor

No description provided.

@RanMaoyi
* MDF [conf] Add remote/local_topic forwards_list to struct topic
b07e5a9 
Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
@RanMaoyi
* MDF [conf] Refactor bridge subscription conf parse func
16deafc 
Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
@RanMaoyi
* MDF [conf] Refactor subscriptions destory logic
4ab3730 
Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
@RanMaoyi
* MDF [conf] Fix output log of bridge subscriptions
5dd02e4 
Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
@RanMaoyi
* MDF [conf] Add conf_bridge_node_parse_forwards
b3ff3e5 
Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
@RanMaoyi
* MDF [conf] Rename forwards to forwards_list
4c896f3 
Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
@RanMaoyi
* MDF [conf] Use new function to parse bridge forwards param
89e9714 
Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
@RanMaoyi
* MDF [conf] Fix bridge forwards param destory logic
50ca571 
Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
@RanMaoyi
* MDF [conf] Fix output log of bridge forwards
3c656c4 
Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
@RanMaoyi
* MDF [conf_ver2] Refactor bridge subscription parse logic
925837e 
Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
@RanMaoyi
* MDF [conf_ver2] Refactor bridge forwards param parse logic
a746224 
Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
@RanMaoyi
* MDF [conf_ver2] Refactor aws bridge forwards parse logic
291d26b 
Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
@RanMaoyi RanMaoyi marked this pull request as draft September 14, 2023 09:39
@RanMaoyi RanMaoyi marked this pull request as ready for review September 15, 2023 07:34
@RanMaoyi RanMaoyi changed the title [WIP]topic reflection topic reflection Sep 15, 2023
@RanMaoyi RanMaoyi mentioned this pull request Sep 15, 2023
Merged
wanghaEMQ
wanghaEMQ approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@wanghaEMQ wanghaEMQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@JaylinYu
Copy link
Member

This breaks CI

@JaylinYu
Copy link
Member

@RanMaoyi plz fix CI, will merge this first

@JaylinYu JaylinYu merged commit 17bc3e0 into main Sep 17, 2023
1 of 15 checks passed
@JaylinYu JaylinYu deleted the moi_topic_reflection branch September 17, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaylinYu JaylinYu JaylinYu approved these changes

@xinyi-xs xinyi-xs xinyi-xs approved these changes

@wanghaEMQ wanghaEMQ wanghaEMQ approved these changes

@OdyWayne OdyWayne Awaiting requested review from OdyWayne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RanMaoyi @JaylinYu @xinyi-xs @wanghaEMQ