Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Ringbuffer with key and export some api for get messages from exchange_client #752

Merged
merged 11 commits into from Dec 6, 2023

Conversation

RanMaoyi
Copy link
Contributor

@RanMaoyi RanMaoyi commented Dec 5, 2023

Work in process
Need more tests

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 120 lines in your changes are missing coverage. Please review.

Comparison is base (f6afb2b) 65.64% compared to head (ab05e04) 65.57%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/mqtt/protocol/exchange/exchange_client.c 24.77% 85 Missing ⚠️
src/supplemental/nanolib/ringbuffer/ringbuffer.c 2.85% 34 Missing ⚠️
src/supplemental/nanolib/conf_ver2.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #752      +/-   ##
==========================================
- Coverage   65.64%   65.57%   -0.07%     
==========================================
  Files         124      124              
  Lines       35727    35878     +151     
==========================================
+ Hits        23453    23528      +75     
- Misses      12274    12350      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
JaylinYu

This comment was marked as off-topic.

@JaylinYu JaylinYu merged commit d17200b into main Dec 6, 2023
11 of 16 checks passed
@JaylinYu JaylinYu deleted the moi_ringbuffer branch December 6, 2023 02:57
@RanMaoyi
Copy link
Contributor Author

RanMaoyi commented Dec 6, 2023

thats all?

@JaylinYu Currently, there are still some header file dependency issues that need to be resolved. The main issue is that 'conf.h' includes 'exchange_client.h,' and 'exchange_client.h' has a dependency on 'ringbuffer.h,' which includes 'nng_impl.h.' On the NanoMQ side, including 'nng_impl.h' causes header file path errors. Additionally, there are some test cases that still require confirmation of lock order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants