tlstran_pipe_stop should free cparam #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lee <lkyjason91@gmail.com>
lkyjason
force-pushed
the
lkyjason/1519-conn-param-leak
branch
from
5da0982
to
ee192e1
Compare
|
Thank you for your contribution! But we usually do frees in pipe_fini not pipe_stop. We will appreciate it if you can move all these to tlstran_pipe_fini, just like what we do in tcptran_pipe_fini. Or should I do it for you? |
OdyWayne
requested changes
Dec 7, 2023
Signed-off-by: Jason Lee <lkyjason91@gmail.com>
|
@OdyWayne moved to pipe_fini :) |
JaylinYu
approved these changes
Dec 8, 2023
|
Some modification we did on broker_tcp needs to be synced to broker_tls |
OdyWayne
approved these changes
Dec 8, 2023
|
well done |
|
Thank you @OdyWayne |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1519 Several memleaks in TLS
NanoMQ issue: nanomq/nanomq#1519
p->tcp_cparam that is allocated in tlstran_pipe_nego_cb is not freed by tlstran_pipe_stop, instead the variable is directly set to NULL resulting in memory leak.