broker_tcp/tls sync #762
Merged
broker_tcp/tls sync #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wayne <yukang.wei@emqx.io>
Signed-off-by: wayne <yukang.wei@emqx.io>
Signed-off-by: wayne <yukang.wei@emqx.io>
Signed-off-by: wayne <yukang.wei@emqx.io>
Signed-off-by: wayne <yukang.wei@emqx.io>
Signed-off-by: wayne <yukang.wei@emqx.io>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #762 +/- ##
==========================================
+ Coverage 64.70% 64.73% +0.03%
==========================================
Files 124 124
Lines 35879 35902 +23
==========================================
+ Hits 23215 23241 +26
+ Misses 12664 12661 -3 ☔ View full report in Codecov by Sentry. |
OdyWayne
commented
Dec 12, 2023
| @@ -1,6 +1,7 @@ | |||
| #ifndef NANOLIB_ACL_CONF_H | |||
| #define NANOLIB_ACL_CONF_H | |||
|
|
|||
| #include <string.h> | |||
There was a problem hiding this comment.
darwin can't find string
Signed-off-by: wayne <yukang.wei@emqx.io>
Signed-off-by: wayne <yukang.wei@emqx.io>
Signed-off-by: wayne <yukang.wei@emqx.io>
Signed-off-by: wayne <yukang.wei@emqx.io>
…e got closed abruptly Signed-off-by: wayne <yukang.wei@emqx.io>
…qos_send cb Signed-off-by: wayne <yukang.wei@emqx.io>
Signed-off-by: wayne <yukang.wei@emqx.io>
Signed-off-by: wayne <yukang.wei@emqx.io>
xinyi-xs
approved these changes
Dec 12, 2023
RanMaoyi
approved these changes
Dec 13, 2023
JaylinYu
approved these changes
Dec 13, 2023
| @@ -470,7 +469,13 @@ nmq_tcptran_pipe_qos_send_cb(void *arg) | |||
| return; | |||
| } | |||
| msg = nni_aio_get_msg(qsaio); | |||
| type = nni_msg_cmd_type(msg); | |||
| if (msg != NULL) | |||
| type = nni_msg_cmd_type(msg); | |||
| @@ -1069,9 +1078,8 @@ nmq_pipe_send_start_v4(tcptran_pipe *p, nni_msg *msg, nni_aio *aio) | |||
| // TODO packetid already exists. | |||
| // do we need to replace old with new | |||
| // one ? print warning to users | |||
| nni_println( | |||
| "ERROR: packet id duplicates in " | |||
| "nano_qos_db"); | |||
| @@ -463,8 +483,8 @@ tlstran_pipe_qos_send_cb(void *arg) | |||
| return; | |||
| } | |||
|
|
|||
| if (p->tcp_cparam->pro_ver == 5) { | |||
| (type == CMD_PUBCOMP || type == PUBACK) ? p->qrecv_quota++ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.