Fix ringbuffer exchange exchange_client UT #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
directly Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #767 +/- ##
==========================================
+ Coverage 64.51% 65.78% +1.26%
==========================================
Files 124 124
Lines 35999 35975 -24
==========================================
+ Hits 23226 23666 +440
+ Misses 12773 12309 -464 ☔ View full report in Codecov by Sentry. |
JaylinYu
approved these changes
Dec 13, 2023
| @@ -99,6 +99,7 @@ exchange_node_send_messages_dequeue(exchange_node_t *ex_node, int **key, nni_msg | |||
| *aio = send_msg->aio; | |||
| nni_list_remove(&ex_node->send_messages, send_msg); | |||
| ex_node->send_messages_num--; | |||
| nng_free(send_msg, sizeof(*send_msg)); | |||
There was a problem hiding this comment.
better use lmq here.
put aio in msg->protodata
| @@ -223,6 +223,12 @@ int ringBuffer_enqueue(ringBuffer_t *rb, | |||
| } | |||
|
|
|||
| if (rb->size == rb->cap) { | |||
| /* ringbuffer not allowed to overwrite */ | |||
| if (rb->overWrite == 0) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.