Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a New Parquet Write Strategy & Support read configuration to enable parquet #769

Merged
merged 7 commits into from Dec 14, 2023
Merged

Introduce a New Parquet Write Strategy & Support read configuration to enable parquet #769

merged 7 commits into from Dec 14, 2023

Conversation

xinyi-xs
Copy link
Contributor

No description provided.

@codecov Codecov
Copy link

codecov bot commented Dec 14, 2023 •
edited

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (deb5325) 65.66% compared to head (8a945e3) 65.77%.
Report is 5 commits behind head on main.

Files Patch % Lines
src/supplemental/nanolib/conf.c 37.03% 17 Missing ⚠️
src/supplemental/nanolib/conf_ver2.c 40.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #769      +/-   ##
==========================================
+ Coverage   65.66%   65.77%   +0.11%     
==========================================
  Files         124      124              
  Lines       35975    36012      +37     
==========================================
+ Hits        23622    23688      +66     
+ Misses      12353    12324      -29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghaEMQ
* FIX [conf] Move parquet_conf from parquet to conf.h
36a9f43 
Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* NEW [conf] Support read parquet configuration.
f3154bb 
Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* NEW [conf] Set default value for parquet configuration.
a58531a 
Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* NEW [conf] Support print parquet configuration.
8a945e3 
Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ wanghaEMQ mentioned this pull request Dec 14, 2023
Merged
@JaylinYu JaylinYu merged commit aeec4c9 into main Dec 14, 2023
11 of 16 checks passed
@JaylinYu JaylinYu deleted the xinyi/parquet branch December 14, 2023 10:29
@wanghaEMQ wanghaEMQ changed the title Introducing a New Parquet Write Strategy Introduce a New Parquet Write Strategy & Support read configuration to enable parquet Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RanMaoyi RanMaoyi RanMaoyi approved these changes

@OdyWayne OdyWayne OdyWayne approved these changes

@JaylinYu JaylinYu JaylinYu approved these changes

@wanghaEMQ wanghaEMQ wanghaEMQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@xinyi-xs @RanMaoyi @OdyWayne @JaylinYu @wanghaEMQ