MQ: Exchange: Key value of msg is stored in stack space #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #774 +/- ##
==========================================
+ Coverage 65.72% 65.76% +0.03%
==========================================
Files 124 124
Lines 36007 35984 -23
==========================================
- Hits 23667 23664 -3
+ Misses 12340 12320 -20 ☔ View full report in Codecov by Sentry. |
xinyi-xs
approved these changes
Dec 20, 2023
|
Please don't merge it until my PR is already. I will merge it later |
OdyWayne
approved these changes
Dec 20, 2023
Signed-off-by: jaylin <jaylin@emqx.io>
Signed-off-by: jaylin <jaylin@emqx.io>
wanghaEMQ
approved these changes
Dec 21, 2023
|
|
|
@JaylinYu Your commits seems break the unit test of exchange |
Signed-off-by: wayne <yukang.wei@emqx.io>
Signed-off-by: wayne <yukang.wei@emqx.io>
Signed-off-by: jaylin <jaylin@emqx.io>
UT begin aio before sock_send, fixed now |
JaylinYu
force-pushed
the
moi_ringbuffer
branch
from
129c3d2
to
442b516
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.