* MDF [conf] enable bridge retain flag in old conf #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wayne <yukang.wei@emqx.io>
Signed-off-by: wayne <yukang.wei@emqx.io>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #795 +/- ##
==========================================
- Coverage 65.62% 63.29% -2.34%
==========================================
Files 123 123
Lines 35996 36021 +25
==========================================
- Hits 23624 22801 -823
- Misses 12372 13220 +848 ☔ View full report in Codecov by Sentry. |
wanghaEMQ
approved these changes
Jan 4, 2024
Signed-off-by: wayne <yukang.wei@emqx.io>
wanghaEMQ
approved these changes
Jan 4, 2024
Signed-off-by: wayne <yukang.wei@emqx.io>
RanMaoyi
approved these changes
Jan 4, 2024
Signed-off-by: wayne <yukang.wei@emqx.io>
xinyi-xs
approved these changes
Jan 4, 2024
Signed-off-by: wayne <yukang.wei@emqx.io>
Signed-off-by: wayne <yukang.wei@emqx.io>
OdyWayne
commented
Jan 4, 2024
| # # # Value: Number | ||
| # # # Default: 5 | ||
| # file_count = 5 | ||
| # } |
There was a problem hiding this comment.
There are plenty of memleaks in conf parse in exchange & parquet now.
There was a problem hiding this comment.
There are plenty of memleaks in conf parse in exchange & parquet now.
I have made some updates. Those memory leakage will no longer exists after that pr was merged.
Signed-off-by: wayne <yukang.wei@emqx.io>
JaylinYu
approved these changes
Jan 5, 2024
src/supplemental/nanolib/conf_ver2.c
Outdated
| } else { | ||
| nng_strfree(param->name); | ||
| NNI_FREE_STRUCT(param); | ||
| } | ||
| } | ||
| config->param_count = cvector_size(config->params); | ||
| config->param_count = cnt; |
|
|
||
| ## multi-stream: enable or disable the multi-stream bridging mode | ||
| ## Still a feature WIP, but basic func is ready | ||
| ## Value: true/false | ||
| ## Default: false | ||
| bridge.mqtt.emqx.quic_multi_stream=true | ||
| bridge.mqtt.emqx.quic_multi_stream=false |
| # # # Value: Number | ||
| # # # Default: 5 | ||
| # file_count = 5 | ||
| # } |
Signed-off-by: wayne <yukang.wei@emqx.io>
Signed-off-by: wayne <yukang.wei@emqx.io>
Signed-off-by: wayne <yukang.wei@emqx.io>
Signed-off-by: wayne <yukang.wei@emqx.io>
RanMaoyi
approved these changes
Jan 5, 2024
JaylinYu
approved these changes
Jan 6, 2024
| @@ -105,6 +105,6 @@ NUTS_TESTS = { | |||
| {"get size", test_get_size}, | |||
| {"get time", test_get_time}, | |||
| {"conf parse v2", test_conf_parse_ver2}, | |||
| {"conf parse", test_conf_parse}, | |||
| // {"conf parse", test_conf_parse}, | |||
There was a problem hiding this comment.
remember to fire an issue regarding this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.