New fuzz search api for exchange_server and ringbuffer #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
wanghaEMQ
approved these changes
Jan 8, 2024
| @@ -91,4 +91,9 @@ int ringBuffer_release(ringBuffer_t *rb); | |||
|
|
|||
| int ringBuffer_search_msg_by_key(ringBuffer_t *rb, uint64_t key, nng_msg **msg); | |||
| int ringBuffer_search_msgs_by_key(ringBuffer_t *rb, uint64_t key, uint32_t count, nng_msg ***list); | |||
| int ringBuffer_search_msgs_fuzz(ringBuffer_t *rb, | |||
There was a problem hiding this comment.
seems inconsistent with function declarations before
|
CI is crashing with some strange error. It doesn't fail with debug asan enabled.🤔 |
Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
wanghaEMQ
approved these changes
Jan 8, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #798 +/- ##
==========================================
+ Coverage 63.12% 63.23% +0.10%
==========================================
Files 123 123
Lines 36101 36164 +63
==========================================
+ Hits 22789 22867 +78
+ Misses 13312 13297 -15 ☔ View full report in Codecov by Sentry. |
fixed |
OdyWayne
approved these changes
Jan 8, 2024
JaylinYu
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.