Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support fuzz search request in sock_recv #805

Merged
merged 2 commits into from Jan 11, 2024
Merged

Support fuzz search request in sock_recv #805

merged 2 commits into from Jan 11, 2024

Conversation

RanMaoyi
Copy link
Contributor

No description provided.

@RanMaoyi
* MDF [exchange_server] Support fuzz search request in sock_recv
7b4733a 
Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
@codecov Codecov
Copy link

codecov bot commented Jan 11, 2024 •
edited

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (255d43a) 63.63% compared to head (e584fbc) 63.54%.

Files Patch % Lines
src/mqtt/protocol/exchange/exchange_server.c 72.72% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #805      +/-   ##
==========================================
- Coverage   63.63%   63.54%   -0.09%     
==========================================
  Files         129      129              
  Lines       37072    37086      +14     
==========================================
- Hits        23589    23566      -23     
- Misses      13483    13520      +37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RanMaoyi
* MDF [UT] Fix exchange_server UT
e584fbc 
Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
wanghaEMQ
wanghaEMQ approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@wanghaEMQ wanghaEMQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

JaylinYu
JaylinYu approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@JaylinYu JaylinYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do the same for recv_cb?

@JaylinYu JaylinYu merged commit 3151f92 into main Jan 11, 2024
15 of 16 checks passed
@JaylinYu JaylinYu deleted the moi_dev branch January 11, 2024 11:12
@RanMaoyi
Copy link
Contributor Author

do the same for recv_cb?

recv_cb need to decode msg to binary and send with JSON to consumer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OdyWayne OdyWayne OdyWayne approved these changes

@JaylinYu JaylinYu JaylinYu approved these changes

@xinyi-xs xinyi-xs xinyi-xs approved these changes

@wanghaEMQ wanghaEMQ wanghaEMQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@RanMaoyi @OdyWayne @JaylinYu @xinyi-xs @wanghaEMQ