Fix #812 #826
Merged
Fix #812 #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jaylin <jaylin@emqx.io>
JaylinYu
force-pushed
the
jaylin/develop
branch
from
dd6e274
to
0378aad
Compare
|
Can confirm seg fault no longer appears when connecting via paho-mqtt. aarch64 with latest nanomq head, this nng branch, and built with |
|
thanks， will fix ci and have a release this month! |
xinyi-xs
approved these changes
Jan 25, 2024
Signed-off-by: jaylin <jaylin@emqx.io>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #826 +/- ##
==========================================
- Coverage 65.76% 65.64% -0.13%
==========================================
Files 129 129
Lines 37297 37302 +5
==========================================
- Hits 24530 24488 -42
- Misses 12767 12814 +47 ☔ View full report in Codecov by Sentry. |
wanghaEMQ
reviewed
Jan 25, 2024
src/sp/transport/mqtt/broker_tcp.c
Outdated
| // duplicated with fixed_header_adaptor | ||
| nni_msg_set_remaining_len(msg, len); | ||
| // fixed_header_adaptor(p->rxlen, msg); | ||
| nni_msg_set_remaining_len(msg, nni_msg_len(msg)); |
Signed-off-by: jaylin <jaylin@emqx.io>
Signed-off-by: jaylin <jaylin@emqx.io>
Signed-off-by: jaylin <jaylin@emqx.io>
…f get_var_integar Signed-off-by: jaylin <jaylin@emqx.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.