Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose exchange url #850

Merged
merged 4 commits into from
Feb 10, 2024
Merged

expose exchange url #850

merged 4 commits into from
Feb 10, 2024

Conversation

JaylinYu
Copy link
Member

@JaylinYu JaylinYu commented Feb 5, 2024

No description provided.

src/supplemental/nanolib/conf_ver2.c Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0c6e7b8) 65.51% compared to head (ba9d4c6) 65.52%.

❗ Current head ba9d4c6 differs from pull request most recent head 7e92043. Consider uploading reports for the commit 7e92043 to get more accurate results

Files Patch % Lines
src/supplemental/nanolib/conf_ver2.c 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #850      +/-   ##
==========================================
+ Coverage   65.51%   65.52%   +0.01%     
==========================================
  Files         129      129              
  Lines       37382    37383       +1     
==========================================
+ Hits        24491    24497       +6     
+ Misses      12891    12886       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wanghaEMQ wanghaEMQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

… conf)

Signed-off-by: jaylin <jaylin@emqx.io>
Signed-off-by: jaylin <jaylin@emqx.io>
Signed-off-by: jaylin <jaylin@emqx.io>
Signed-off-by: jaylin <jaylin@emqx.io>
@JaylinYu JaylinYu merged commit fd186e1 into main Feb 10, 2024
14 of 15 checks passed
@JaylinYu JaylinYu deleted the jaylin/develop branch February 10, 2024 09:13
Copy link
Member

@wanghaEMQ wanghaEMQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants