Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the blf library. #863

Merged
merged 4 commits into from Feb 23, 2024
Merged

Introduce the blf library. #863

merged 4 commits into from Feb 23, 2024

Conversation

xinyi-xs
Copy link
Contributor

No description provided.

Signed-off-by: lee-emqx <lihj@emqx.io>
Signed-off-by: lee-emqx <lihj@emqx.io>
Signed-off-by: lee-emqx <lihj@emqx.io>

# Set the default search paths
set(Vector_BLF_INCLUDE_DIRS "/usr/include" "/usr/local/include")
set(Vector_BLF_LIBRARY_DIRS "/usr/lib" "/usr/local/lib")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expose this as a cmake settings?

add_subdirectory(parquet)
add_subdirectory(blf)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NNG_ENABLE_BLF ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the NNG project, we use "NNG" as a prefix.

src/supplemental/nanolib/blf/CMakeLists.txt Show resolved Hide resolved
src/supplemental/nanolib/blf/blf.cc Outdated Show resolved Hide resolved
Copy link
Member

@wanghaEMQ wanghaEMQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@JaylinYu JaylinYu marked this pull request as draft February 20, 2024 03:52
@xinyi-xs xinyi-xs marked this pull request as ready for review February 23, 2024 09:10
Signed-off-by: lee-emqx <lihj@emqx.io>
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.58%. Comparing base (cfcda8c) to head (f2f7e61).
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #863      +/-   ##
==========================================
+ Coverage   65.36%   65.58%   +0.21%     
==========================================
  Files         129      129              
  Lines       37401    37401              
==========================================
+ Hits        24448    24529      +81     
+ Misses      12953    12872      -81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JaylinYu JaylinYu merged commit 26986b9 into main Feb 23, 2024
14 of 16 checks passed
@JaylinYu JaylinYu deleted the xinyi/blf branch February 23, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants