New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce the blf library. #863
Conversation
Signed-off-by: lee-emqx <lihj@emqx.io>
Signed-off-by: lee-emqx <lihj@emqx.io>
Signed-off-by: lee-emqx <lihj@emqx.io>
|
||
# Set the default search paths | ||
set(Vector_BLF_INCLUDE_DIRS "/usr/include" "/usr/local/include") | ||
set(Vector_BLF_LIBRARY_DIRS "/usr/lib" "/usr/local/lib") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expose this as a cmake settings?
add_subdirectory(parquet) | ||
add_subdirectory(blf) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NNG_ENABLE_BLF ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the NNG project, we use "NNG" as a prefix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool
Signed-off-by: lee-emqx <lihj@emqx.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #863 +/- ##
==========================================
+ Coverage 65.36% 65.58% +0.21%
==========================================
Files 129 129
Lines 37401 37401
==========================================
+ Hits 24448 24529 +81
+ Misses 12953 12872 -81 ☔ View full report in Codecov by Sentry. |
No description provided.