Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx #884 #885

Merged
merged 2 commits into from Mar 5, 2024
Merged

FIx #884 #885

merged 2 commits into from Mar 5, 2024

Conversation

JaylinYu
Copy link
Member

@JaylinYu JaylinYu commented Mar 5, 2024

No description provided.

phsilva and others added 2 commits March 4, 2024 12:03
NNG_MAX_EXPIRE_THREADS docs say that 0 means unlimited, but there is a
code check that imposes a limit between [1, 256].

This commit fixes the doc.
Signed-off-by: jaylin <jaylin@emqx.io>
@JaylinYu JaylinYu requested a review from RanMaoyi March 5, 2024 04:13
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 65.17%. Comparing base (98e6304) to head (dfa98d5).

Files Patch % Lines
src/supplemental/mqtt/mqtt_public.c 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #885      +/-   ##
==========================================
- Coverage   65.19%   65.17%   -0.03%     
==========================================
  Files         130      130              
  Lines       37947    37963      +16     
==========================================
+ Hits        24739    24741       +2     
- Misses      13208    13222      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@RanMaoyi RanMaoyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE

@JaylinYu JaylinYu merged commit fd96a6a into main Mar 5, 2024
11 of 16 checks passed
@JaylinYu JaylinYu deleted the jaylin/develop branch March 5, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants