Merge mqttv311 protocol layer with mqttv5 protocol layer #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wanghaemq <wangwei@emqx.io>
Signed-off-by: wanghaemq <wangwei@emqx.io>
Signed-off-by: wanghaemq <wangwei@emqx.io>
Signed-off-by: wanghaemq <wangwei@emqx.io>
Signed-off-by: wanghaemq <wangwei@emqx.io>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #902 +/- ##
==========================================
+ Coverage 65.06% 65.27% +0.21%
==========================================
Files 130 129 -1
Lines 37891 37395 -496
==========================================
- Hits 24655 24411 -244
+ Misses 13236 12984 -252 ☔ View full report in Codecov by Sentry. |
* ADD [mqtt/proto] Add some logs. Signed-off-by: wanghaemq <wangwei@emqx.io>
wanghaEMQ
changed the title
JaylinYu
approved these changes
Mar 29, 2024
| nni_mtx_unlock(&s->mtx); | ||
| nni_msg_free(msg); | ||
| // close pipe directly, no DISCONNECT for MQTTv3.1.1 | ||
| // close pipe directly |
There was a problem hiding this comment.
shall we send a DISCONNECT here for V5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.