Fix server critical QUIC bugs. #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wanghaEMQ
commented
May 14, 2024
•
wanghaEMQ
commented
- Fixed the double free on qos msg in protocol.
- Fixed the unguard unack map.
- Fixed the error that quic connection may getting stuck in closing.
- Fixed heap use after free on ackmsg sending when sending in msquic failed.
- Fixed the repeat quic connection close.
Signed-off-by: wanghaemq <wangwei@emqx.io>
Signed-off-by: wanghaemq <wangwei@emqx.io>
…ocol layer. Signed-off-by: wanghaemq <wangwei@emqx.io>
…quic prior sending. Signed-off-by: wanghaemq <wangwei@emqx.io>
Signed-off-by: wanghaemq <wangwei@emqx.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #943 +/- ##
==========================================
- Coverage 65.13% 65.04% -0.10%
==========================================
Files 129 129
Lines 37416 37620 +204
==========================================
+ Hits 24372 24469 +97
- Misses 13044 13151 +107 ☔ View full report in Codecov by Sentry. |
JaylinYu
approved these changes
May 14, 2024
xinyi-xs
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.