Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some gap between nng reap thread and msquic. #947

Merged
merged 4 commits into from
May 15, 2024
Merged

Fix some gap between nng reap thread and msquic. #947

merged 4 commits into from
May 15, 2024

Conversation

wanghaEMQ
Copy link
Member

  • The pack max restrict should be applied to both mqttv311 and mqtv5.
  • Fix the double free of msg when cancel stream sending.
  • Fix the double free of quic stream.

@wanghaEMQ
* FIX [quic] Fix the double free when cancel stream send.
56c4952 
Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* NEW [quic] Add refcnt for nni quic conn to avoid the data race in f…
82e7111 
…ree it.

Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* FIX [trans/quic] Fix the max size error in setting.
b257f19 
Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* FIX [trans/quic] packmax should be applied to both mqttv311 and mqtv5.
63d4b4d 
Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ wanghaEMQ requested review from JaylinYu, RanMaoyi, OdyWayne and xinyi-xs and removed request for JaylinYu May 15, 2024 10:06
@wanghaEMQ wanghaEMQ changed the title Wangha/fix Fix some gap between nng reap thread and msquic. May 15, 2024
JaylinYu
JaylinYu approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@JaylinYu JaylinYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a quic pipe ref is added, I cannot spot bug by just watch, have to rely on u at this PR now. will test more later

src/supplemental/quic/msquic_dial.c
// It's the only place to free msquic stream
msquic_strm_fini(c->qstrm);
quic_stream_error(arg, NNG_ECONNSHUT);
quic_stream_rele(c);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an essential fix

src/supplemental/quic/msquic_dial.c
static void
quic_stream_rele(nni_quic_conn *c)
{
quic_stream_close(c);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow a big change

@JaylinYu JaylinYu merged commit 4723ee9 into main May 15, 2024
15 checks passed
@JaylinYu JaylinYu deleted the wangha/fix branch May 15, 2024 10:33
@wanghaEMQ wanghaEMQ mentioned this pull request May 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RanMaoyi RanMaoyi RanMaoyi approved these changes

@JaylinYu JaylinYu JaylinYu approved these changes

@xinyi-xs xinyi-xs xinyi-xs approved these changes

@OdyWayne OdyWayne Awaiting requested review from OdyWayne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wanghaEMQ @RanMaoyi @JaylinYu @xinyi-xs