Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the key to exchange. key=hash(clientid+topic+id). #1609

Merged
merged 2 commits into from Jan 26, 2024
Merged

Update the key to exchange. key=hash(clientid+topic+id). #1609

merged 2 commits into from Jan 26, 2024

Conversation

wanghaEMQ
Copy link
Member

No description provided.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 19, 2024
View reviewed changes
nanomq/webhook_post.c
Comment on lines +261 to +262
// log_info("%s - %s - %s => %lx %llx", clientid, topic, buf, key32, res);
// nng_time ts = nng_timestamp();

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
nanomq/webhook_post.c Fixed Show fixed Hide fixed
nanomq/webhook_post.c Fixed Show fixed Hide fixed
@RanMaoyi
Copy link
Contributor

The test succeeded with the ringbuffer changes, but please check for CodeQL failures

@codecov Codecov
Copy link

codecov bot commented Jan 24, 2024 •
edited

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (62d91ed) 55.93% compared to head (b61725e) 55.77%.
Report is 22 commits behind head on master.

❗ Current head b61725e differs from pull request most recent head 2483d20. Consider uploading reports for the commit 2483d20 to get more accurate results

Files Patch % Lines
nanomq/webhook_post.c 5.00% 19 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1609      +/-   ##
==========================================
- Coverage   55.93%   55.77%   -0.17%     
==========================================
  Files          18       18              
  Lines        6842     6860      +18     
==========================================
- Hits         3827     3826       -1     
- Misses       3015     3034      +19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghaEMQ
* FIX [hook] Increate the length of buf that put a u32.
2483d20 
Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
Copy link
Member Author

The test succeeded with the ringbuffer changes, but please check for CodeQL failures

Fixed

@wanghaEMQ wanghaEMQ marked this pull request as ready for review January 26, 2024 08:08
@wanghaEMQ wanghaEMQ changed the title [WIP] Update the key to exchange. key=hash(clientid+topic+id). Update the key to exchange. key=hash(clientid+topic+id). Jan 26, 2024
JaylinYu
JaylinYu approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@JaylinYu JaylinYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is another issue

@JaylinYu JaylinYu merged commit 81df65d into master Jan 26, 2024
84 of 87 checks passed
@JaylinYu JaylinYu deleted the wangha/dev branch January 26, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RanMaoyi RanMaoyi RanMaoyi approved these changes

@JaylinYu JaylinYu JaylinYu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wanghaEMQ @RanMaoyi @JaylinYu