Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new http api update config. #1648

Merged
merged 2 commits into from Jan 31, 2024
Merged

Add new http api update config. #1648

merged 2 commits into from Jan 31, 2024

Conversation

xinyi-xs
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (7ec9975) 56.01% compared to head (3693ae3) 55.88%.

❗ Current head 3693ae3 differs from pull request most recent head 52f824d. Consider uploading reports for the commit 52f824d to get more accurate results

Files Patch % Lines
nanomq/rest_api.c 15.78% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1648      +/-   ##
==========================================
- Coverage   56.01%   55.88%   -0.14%     
==========================================
  Files          18       18              
  Lines        6887     6905      +18     
==========================================
+ Hits         3858     3859       +1     
- Misses       3029     3046      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: lee-emqx <lihj@emqx.io>
Signed-off-by: lee-emqx <lihj@emqx.io>
Copy link
Member

@JaylinYu JaylinYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to restart nanomq

nanomq/rest_api.c Fixed Show fixed Hide fixed
@JaylinYu
Copy link
Member

Remember to restart nanomq

My bad, not needed

@JaylinYu JaylinYu merged commit 80edc21 into master Jan 31, 2024
88 checks passed
@JaylinYu JaylinYu deleted the xinyi/http branch January 31, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants