New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix several typos after reviewing webserver #1659
Conversation
… name with a global variable. Signed-off-by: wanghaemq <wangwei@emqx.io>
… both of them are extern... Signed-off-by: wanghaemq <wangwei@emqx.io>
Signed-off-by: wanghaemq <wangwei@emqx.io>
NNG_FLAG_NONBLOCK)) != 0) { | ||
NANO_NNG_FATAL("nng_dial " INPROC_SERVER_URL, rv); | ||
} | ||
|
||
for (size_t i = 0; i < rest_conf->parallel; i++) { | ||
works[i] = alloc_work(sock, rest_conf); | ||
|
||
works[i]->client_sock = &req_sock; | ||
works[i]->client_sock = &client_sock; |
Check warning
Code scanning / CodeQL
Local variable address stored in non-local memory Warning
source
@@ -453,6 +453,8 @@ post_ctrl(http_msg *msg, proxy_info *proxy, const char *type) | |||
return res; | |||
} | |||
|
|||
// TODO FIXME Same function name with the function in nanomq/rest_api.c | |||
// Both of them are extern... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this http_msg process_request(http_msg *msg, proxy_info *proxy)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not pretty sure what is this pr about
No description provided.