Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #1719 #1721

Merged
merged 6 commits into from
Mar 29, 2024
Merged

fix #1719 #1721

merged 6 commits into from
Mar 29, 2024

Conversation

OdyWayne
Copy link
Collaborator

No description provided.

@OdyWayne
* FIX [bridge] fix memleak in bridge
a239d22 
Signed-off-by: wayne <yukang.wei@emqx.io>
@OdyWayne
* FIX [cmd_proc] fix memleak #1719 2
ae309f7 
Signed-off-by: wayne <yukang.wei@emqx.io>
@OdyWayne
* FIX [webhook_inproc] fix memleak #1719 7
959b68f 
Signed-off-by: wayne <yukang.wei@emqx.io>
@OdyWayne
* FIX [webhook_post] fix memleak #1719 8
f9c5d25 
Signed-off-by: wayne <yukang.wei@emqx.io>
OdyWayne
OdyWayne commented Mar 26, 2024
View reviewed changes
nanomq/webhook_post.c Outdated Show resolved Hide resolved
wanghaEMQ
wanghaEMQ requested changes Mar 26, 2024
View reviewed changes
nanomq/cmd_proc.c Outdated Show resolved Hide resolved
nanomq/webhook_inproc.c Show resolved Hide resolved
nanomq/webhook_post.c Outdated Show resolved Hide resolved
@OdyWayne
* MDF [cmd_proc] revert fix for #1719 2
022cf2a 
Signed-off-by: wayne <yukang.wei@emqx.io>
@codecov Codecov
Copy link

codecov bot commented Mar 26, 2024 •
edited

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 53.86%. Comparing base (3f35ac4) to head (854b139).
Report is 1 commits behind head on master.

Files Patch % Lines
nanomq/bridge.c 0.00% 13 Missing ⚠️
nanomq/webhook_post.c 0.00% 7 Missing ⚠️
nanomq/webhook_inproc.c 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1721      +/-   ##
==========================================
- Coverage   54.96%   53.86%   -1.10%     
==========================================
  Files          18       18              
  Lines        7044     7069      +25     
==========================================
- Hits         3872     3808      -64     
- Misses       3172     3261      +89

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

wanghaEMQ
wanghaEMQ requested changes Mar 27, 2024
View reviewed changes
nanomq/webhook_inproc.c Show resolved Hide resolved
@OdyWayne
* FIX [webhook_inproc] fix wild piont
854b139 
Signed-off-by: wayne <yukang.wei@emqx.io>
@OdyWayne OdyWayne mentioned this pull request Mar 28, 2024
Closed
@JaylinYu
Copy link
Member

BLF & Parquet shall not be enabled together for now.

@JaylinYu JaylinYu merged commit 8988d41 into master Mar 29, 2024
90 checks passed
@JaylinYu JaylinYu deleted the wayne/dev branch March 29, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaylinYu JaylinYu JaylinYu approved these changes

@wanghaEMQ wanghaEMQ wanghaEMQ approved these changes

@RanMaoyi RanMaoyi Awaiting requested review from RanMaoyi

@xinyi-xs xinyi-xs Awaiting requested review from xinyi-xs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@OdyWayne @JaylinYu @wanghaEMQ