http acl support #1724
Merged
http acl support #1724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sth is wrong in CI. |
|
Whoops, I found a websocket bug in the failed CI |
Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
…logic Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
|
will merge this after 0.21.9 is out. |
Signed-off-by: jaylin <jaylin@emqx.io>
JaylinYu
approved these changes
Apr 17, 2024
nanomq/apps/broker.c
Outdated
|
|
||
| rv = nmq_auth_http_sub_pub(work->cparam, true, tq, &work->config->auth_http); | ||
| if (rv != 0) { | ||
| log_error("Auth failed! subscribe packet!"); |
There was a problem hiding this comment.
what if only part of sub topics are not allowed??
nanomq/apps/broker.c
Outdated
| conn_param_free(work->cparam); | ||
| work->code = rv; | ||
| work->state = CLOSE; | ||
| nng_aio_finish(work->aio, 0); |
There was a problem hiding this comment.
just return suback with reason code
| @@ -1103,6 +1104,22 @@ handle_pub(nano_work *work, struct pipe_content *pipe_ct, uint8_t proto, | |||
| topic = work->pub_packet->var_header.publish.topic_name.body; | |||
| uint32_t len = work->pub_packet->var_header.publish.topic_name.len; | |||
|
|
|||
| if (work->config->auth_http.enable) { | |||
| struct topic_queue *tq = topic_queue_init(topic, len); | |||
| if (tq == NULL) { | |||
There was a problem hiding this comment.
only one topic exsits for pub msg
| if (check_properties(sub_pkt->properties) != SUCCESS) { | ||
| if (work->proto_ver == MQTT_PROTOCOL_VERSION_v5) { | ||
| sub_pkt->properties = decode_properties(work->msg, | ||
| (uint32_t *)&bpos, |
|
Whoops MQTT V5 still fail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related on https://github.com/nanomq/NanoNNG/pull/905/files