Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nanomq_cli {bench, sub} sub-commands memory leakage #1745

Merged
merged 2 commits into from Apr 14, 2024
Merged

fix: nanomq_cli {bench, sub} sub-commands memory leakage #1745

merged 2 commits into from Apr 14, 2024

Conversation

lizhanhui
Copy link
Contributor

fix #1138

@lizhanhui
fix: nanomq_cli bench sub memory leak
254041d 
Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
@lizhanhui
fix: memory leak for nanomq_cli sub command
b819ea4 
Signed-off-by: Zhanhui Li <lizhanhui@gmail.com>
@lizhanhui lizhanhui changed the title fix: nanomq_cli bench sub memory leak fix: nanomq_cli {bench, sub} sub-commands memory leakage Apr 11, 2024
@lizhanhui
Copy link
Contributor Author

The Function test failure looks unrelated to this change request.

JaylinYu
JaylinYu approved these changes Apr 14, 2024
View reviewed changes
Copy link
Member

@JaylinYu JaylinYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@JaylinYu JaylinYu merged commit cfcdeff into nanomq:master Apr 14, 2024
45 checks passed
@lizhanhui lizhanhui deleted the fix_memory_leak branch April 15, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaylinYu JaylinYu JaylinYu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nanomq_cli sub cause memleak & suback could be ignored
2 participants
@lizhanhui @JaylinYu