Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spamming "Redialing Datadog" #23

Open
sdomino opened this issue Aug 1, 2018 · 2 comments
Open

Spamming "Redialing Datadog" #23

sdomino opened this issue Aug 1, 2018 · 2 comments

Comments

@sdomino
Copy link
Contributor

sdomino commented Aug 1, 2018

After each message gets published we're setting the connection to nil here

Because of this, each time another publish comes in, we're creating a new connection and outputting "Redialing Datadog" here

This could probably be optimized a bit, however, I don't think there is anything inherently wrong with it, we probably just don't need that output message.

@glinton
Copy link
Contributor

glinton commented Aug 1, 2018

It's actually setting the connection to nil only if there was an error writing on the connection, so it will know to redial. I'd say get rid of the log message though.

@sdomino
Copy link
Contributor Author

sdomino commented Aug 1, 2018

You're right, I misread that initially. For some reason, I read it err == nil. I'll have another look and see where it's causing the spam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants