-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FR: give some control over minimap2 behaviour | write both (un)aligned BAMs #196
Comments
Hi! Thanks for your feedback and request.
This is a very reasonable ask. We would like to expose more options, at the same time not have to re-implement all mm2 options. If you could share the subset you'd be interested in that would be great.
this one I'll need to discuss with our team. writing to 2 outputs is possible but not ideal since it may interfere with overall basecalling speed. I think perhaps in your use case generating fastq/unaligned bams from |
@sklages
|
@iiSeymour - cool, I wasn't aware of that. @tijyojwad - my second point makes no sense anymore when
Maybe .. at least from my current perspective :-) |
I'd also like more minimap2 control. In addition to --secondary, I routinely adjust the -r (bandwidth) option. |
@sklages @wilsonte-umich we've included these options to |
with versions prior to
0.3.0
we ran basecalling (with modified-bases) separated from mapping and methylation calling.On one hand, because
dorado
didn't support it yet, and on the other hand to gain some flexibilty.E.g. we have by far more CPU servers (for all non-basecalling stuff) than GPU servers, so we can more efficiently use our ressources.
Now that
dorado
is capable of mapping "on-the-fly" without much loss in overall speed I'd like to propose two enhancements which would make it more flexible:In contrast to
bonito
dorado
now keeps "supplementary alignments" ... but also emits "secondary alignments" which are of no use for some people .. so here I'd like to have control over minimap's--secondary=yes|no
parameter. Other basic parameters may be of interest as well.In case I'd like to re-map my data on sth like
hg40
or so, I don't want to convert my aligned BAM to unaligned BAM. Ideally I would directdorado
to also write unaligned BAM data (just as it would if we would omit--reference
) along with the aligned BAM.What do you think?
The text was updated successfully, but these errors were encountered: