Fix Issue #12: Incorrect Loading State #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jilio
changed the title
loading state
|
Apparently, my fix doesn't work 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tldr: Fix for #12
In the latest release v0.1.0
loadingstate was being set tofalsein the following line:query/lib/main.ts
Line 178 in de0ca28
This behavior contradicts the previous setup, where the loading state was set to
true:query/lib/main.ts
Line 176 in 132186c
which led to an incorrect
loadingstate as described here: #12This pull request rectifies this issue, ensuring that the loading state functions as intended.