allocate_fd(): fail gracefully if descriptor cannot be allocated #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
wjhun
approved these changes
Jun 15, 2020
File descriptor allocation is triggered by userspace, thus if the allocation fails it should fail gracefully instead of triggering an assertion failure. This commit fixes the "assertion buffer_set_capacity(b, new_len) == new_len failed in src/runtime/buffer.h: buffer_extend() on line 90; halt" error that happens if the application tries to open more files than the system can handle. vector_set(), extend_total() and buffer_extend() have been modified in order to return a boolean value indicating whether the operation was successful.
francescolavra
force-pushed
the
fix/allocate_fd
branch
from
004c24d
to
c1d218a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File descriptor allocation is triggered by userspace, thus if the allocation fails it should fail gracefully instead of triggering an assertion failure.
This commit fixes the "assertion buffer_set_capacity(b, new_len) == new_len failed in src/runtime/buffer.h: buffer_extend() on line 90; halt" error that happens if the application tries to open more files than the system can handle.
vector_set(), extend_total() and buffer_extend() have been modified in order to return a boolean value indicating whether the operation was successful.