Add command flags as quick picks #13
Conversation
Also removed Ops interface
| let args = ["build", filePath]; | ||
|
|
||
| if (configPath) { |
There was a problem hiding this comment.
Are we losing the ability to use a config file to build images?
There was a problem hiding this comment.
oh sorry, that code is currently not being used because build command is not asking config file. I will add it back
There was a problem hiding this comment.
added back by 86b372b
There was a problem hiding this comment.
Probably we should create new issue to add "Build with Config" command ?
There was a problem hiding this comment.
You're right. It's a useful command.
src/cmd/cmdHandler.ts
Outdated
|
|
||
| let mounts = await vscode.window.showInputBox({ | ||
| title: "Mount Points", | ||
| placeHolder: "Comma-separated [volume_id:mount_path]" |
There was a problem hiding this comment.
This requires users to know the volume id beforehand. It would be easier for users to select a volume from the list.
Check this example as inspiration https://github.com/microsoft/vscode-extension-samples/tree/main/quickinput-sample. This would facilitate a lot the selection of a volume.
There was a problem hiding this comment.
I could select an existing volume but wasn't able to mount it on the unikernel. This is what console output shows after executing Ops: Run with a volume selected args: run,/mnt/d/Go/src/github.com/fabiodmferreira/walk-server/main,--imagename,lorem. The argument seems to not be added on executing ops.
UUIDs aren't human friendly. It would be nice to add the volume name on the select options.
There was a problem hiding this comment.
I can see the volume_id:mount_path passed correctly:
args: run,/home/arknable/Development/Project/nanovms/example/hello/hello,--imagename,hello,--mounts,b2858b75-cd8e-631b-9f90-af0d89524dc8:/home/arknable/Development/Project/nanovms/tmp/mounts/a
probably you forgot to select volume id or input the mount path @fabioDMFerreira. anyway I will add volume name also.
the flow is we select volumes then for each selected volume, the extension will ask user to input mount point path. if we don't select any volume, --mounts will not be passed to cli. for each selected volume, if we don't input the mount path, that volume will me omitted.
There was a problem hiding this comment.
I wish there is a way to customize quick pick form but for now this is the only option provided by vscode afaik.
There was a problem hiding this comment.
Volume name added by f5696eb.
There was a problem hiding this comment.
mount flag usage fixed by f6290db
There was a problem hiding this comment.
You're right, I wasn't selecting the volume. I thought it was enough to click enter on the volumes list, but we need to click on the checkbox. I think this happens because it is a multiselect.
Notify user when ops not installed.
Also removed Ops interface
title property is no longer exists in input box option
|
The code seems good though. After deleting the |
No description provided.