Hotfix37 validate uri bug #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s tested in ingest.py. Create Dataset using get_or_create, and return the dataset and the boolean variable returned by get_or_create
…ending django-geo-spaas
… several datasets refer to the same file, or uri
…e, pythesint code is executed on import. This may cause everything to fail if for example the urls of the gcmd keywords have changed - and this happens every no and then..
…com/nansencenter/django-geo-spaas into issue32_customized_nansat_ingestion
3 tasks
Pull Request Test Coverage Report for Build 121
💛 - Coveralls |
|
@korvinos - do you have time to look at this? |
|
@mortenwh Sorry, I am super busy until next week. I will look through it then |
akorosov
approved these changes
Nov 6, 2018
… or it may have a random content. Initialize as uri_filter_args=None and then check inside the method and assign and empty dict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#37
This pull request also contains changes from #32. This is a bit strange, since I thought that was already merged. Anyway, I keep it here...