-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue39 gs6 add params to ingestors #53
Conversation
Pull Request Test Coverage Report for Build 210
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many irrelevant folders have been added to the repos... Please git rm
the following:
- provisioning/.DS_Store
- provisioning/roles/.DS_Store
- provisioning/roles/andrewrothstein.bash/
- provisioning/roles/andrewrothstein.conda-env
- provisioning/roles/andrewrothstein.miniconda
- provisioning/roles/andrewrothstein.unarchive-deps
- provisioning/roles/geospaas/.DS_Store
- provisioning/roles/nansencenter.django
- provisioning/site.retry
These should all be in .gitignore but maybe that hasn't been merged into master yet. Anyway, it will come.
Last thing: do we need the file tests/settings.py?
@@ -56,6 +80,7 @@ def test_getorcreate_localfile(self): | |||
self.assertEqual(ds0.entry_id, self.predefined_metadata_dict['entry_id']) | |||
self.assertEqual(ds0.entry_title, 'NONE') | |||
self.assertEqual(ds0.summary, 'NONE') | |||
self.assertEqual(ds0.parameters.values()[0]['short_name'], self.predefined_band_metadata_dict[2]['short_name']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could do this as a separate test method as well. In general, I prefer one assertion per test and rather having more tests, although this is not necessary to handle now..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a comment to PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
#39