Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to enable notifications (-N, --notify) and disable them by default. #57

Merged
merged 8 commits into from
Oct 18, 2022

Conversation

nao1215
Copy link
Owner

@nao1215 nao1215 commented Oct 18, 2022

I will make a correction for Issue #56.
I would like to add an option to enable notifications (-N, --notify) and disable them by default.

@nao1215 nao1215 mentioned this pull request Oct 18, 2022
4 tasks
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #57 (89d5aa6) into main (984a90e) will increase coverage by 0.71%.
The diff coverage is 95.45%.

@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   90.49%   91.21%   +0.71%     
==========================================
  Files          12       12              
  Lines         463      478      +15     
==========================================
+ Hits          419      436      +17     
+ Misses         28       27       -1     
+ Partials       16       15       -1     
Impacted Files Coverage Δ
cmd/update.go 72.16% <92.30%> (+4.38%) ⬆️
cmd/check.go 96.49% <100.00%> (+0.19%) ⬆️
cmd/import.go 90.32% <100.00%> (+1.86%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nao1215 nao1215 merged commit 4480549 into main Oct 18, 2022
@nao1215 nao1215 deleted the disable-notification-by-default branch May 6, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant