Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use buildinfo #6

Merged
merged 2 commits into from
Feb 22, 2022
Merged

Use buildinfo #6

merged 2 commits into from
Feb 22, 2022

Conversation

mattn
Copy link
Contributor

@mattn mattn commented Feb 22, 2022

Use debug/buildinfo to avoid to spawn "go version -m" for each binary files.

@nao1215
Copy link
Owner

nao1215 commented Feb 22, 2022

@mattn
Thank you for PR! The build is broken, but it will be merged.

This is the second time you have commented.
At first, I didn't know you were famous. Now, I know it.

@nao1215 nao1215 merged commit 7d0adbb into nao1215:main Feb 22, 2022
@nao1215 nao1215 mentioned this pull request Feb 22, 2022
@mattn
Copy link
Contributor Author

mattn commented Feb 22, 2022

Ooops. Sorry. debug/buildinfo is not released 🙇

image

@mattn
Copy link
Contributor Author

mattn commented Feb 22, 2022

Feel free to revert this.

@nao1215
Copy link
Owner

nao1215 commented Feb 22, 2022

Merge after go 1.18 is released.
I will revert once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants