Do simple #7

nao1215 · 2023-10-04T15:20:56Z

No description provided.

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

golangci

mocks_test.go|196 col 1| Function TestMocksHeaderPresentMatcher missing the call to method parallel (paralleltest)
mocks_test.go|220 col 1| Function TestMocksHeaderNotPresentMatcher missing the call to method parallel (paralleltest)
mocks_test.go|244 col 1| Function TestMocksBasicAuth missing the call to method parallel (paralleltest)
mocks_test.go|295 col 1| Function TestMocksQueryMatcherSuccess missing the call to method parallel (paralleltest)
mocks_test.go|322 col 1| Function TestMocksQueryMatcherErrors missing the call to method parallel (paralleltest)
mocks_test.go|350 col 1| Function TestMocksQueryParamsDoesNotOverwriteQuery missing the call to method parallel (paralleltest)
mocks_test.go|363 col 1| Function TestMocksQueryCollection missing the call to method parallel (paralleltest)
mocks_test.go|377 col 1| Function TestMocksQueryCollectionFails missing the call to method parallel (paralleltest)
mocks_test.go|391 col 1| Function TestMocksQueryPresent missing the call to method parallel (paralleltest)
mocks_test.go|412 col 1| Function TestMocksQueryNotPresent missing the call to method parallel (paralleltest)

github-actions · 2023-10-04T15:29:46Z

spectest_test.go

@@ -1309,7 +1309,7 @@ func TestApiTest_CombineFormDataWithMultipart(t *testing.T) {
 	for name, tt := range tests {
 		t.Run(name, func(t *testing.T) {

-			cmd := exec.Command(os.Args[0], "-test.run=TestApiTest_CombineFormDataWithMultipart")
+			cmd := exec.Command(os.Args[0], "-test.run=TestApiTestCombineFormDataWithMultipart")


🚫 [golangci] _{reported by reviewdog 🐶}
G204: Subprocess launched with a potential tainted input or cmd arguments (gosec)

github-actions · 2023-10-04T15:29:47Z

diagram_test.go

@@ -212,7 +212,7 @@ func (m *FS) create(name string) (*os.File, error) {
 	return file, nil
 }

-func (m *FS) mkdirAll(path string, perm os.FileMode) error {
+func (m *FS) mkdirAll(path string, _ os.FileMode) error {


🚫 [golangci] _{reported by reviewdog 🐶}
(*FS).mkdirAll - result 0 (error) is always nil (unparam)

github-actions · 2023-10-04T15:29:47Z

spectest_test.go

@@ -428,7 +428,7 @@ func TestApiTest_AddsBasicAuthToRequest(t *testing.T) {
 		End()
 }

-func TestApiTest_AddsTimedOutContextToRequest(t *testing.T) {
+func TestApiTestAddsTimedOutContextToRequest(t *testing.T) {


🚫 [golangci] _{reported by reviewdog 🐶}
unnecessary leading newline (whitespace)

github-actions · 2023-10-04T15:29:47Z

spectest.go

@@ -753,14 +754,14 @@ func (a *APITest) report() *http.Response {
 	var capturedMockInteractions []*mockInteraction

 	a.observers = append(a.observers, func(finalRes *http.Response, inboundReq *http.Request, a *APITest) {
-		capturedFinalRes = copyHttpResponse(finalRes)
-		capturedInboundReq = copyHttpRequest(inboundReq)
+		capturedFinalRes = copyHTTPResponse(finalRes)


🚫 [golangci] _{reported by reviewdog 🐶}
response body must be closed (bodyclose)

github-actions · 2023-10-04T15:29:47Z

assert_test.go

@@ -5,7 +5,7 @@ import (
 	"testing"
 )

-func TestApiTest_Assert_StatusCodes(t *testing.T) {
+func TestApiTestAssertStatusCodes(t *testing.T) {


🚫 [golangci] _{reported by reviewdog 🐶}
Function TestApiTestAssertStatusCodes missing the call to method parallel (paralleltest)

github-actions · 2023-10-04T15:29:49Z

mocks_test.go

@@ -93,14 +93,14 @@ func TestMocks_CookieNotPresent_FailsToMatch(t *testing.T) {
 	assert.Equal(t, matchError.Error(), "did not expect a cookie with name 'k'")
 }

-func TestMocks_NewUnmatchedMockError_Empty(t *testing.T) {
+func TestMocksNewUnmatchedMockErrorEmpty(t *testing.T) {


🚫 [golangci] _{reported by reviewdog 🐶}
Function TestMocksNewUnmatchedMockErrorEmpty missing the call to method parallel (paralleltest)

github-actions · 2023-10-04T15:29:49Z

mocks_test.go

 	mockError := newUnmatchedMockError()

 	assert.Equal(t, true, mockError != nil)
 	assert.Equal(t, 0, len(mockError.errors))
 }

-func TestMocks_NewEmptyUnmatchedMockError_ExpectedErrorsString(t *testing.T) {
+func TestMocksNewEmptyUnmatchedMockErrorExpectedErrorsString(t *testing.T) {


🚫 [golangci] _{reported by reviewdog 🐶}
Function TestMocksNewEmptyUnmatchedMockErrorExpectedErrorsString missing the call to method parallel (paralleltest)

github-actions · 2023-10-04T15:29:49Z

mocks_test.go

@@ -112,7 +112,7 @@ func TestMocks_NewEmptyUnmatchedMockError_ExpectedErrorsString(t *testing.T) {
 		mockError.Error())
 }

-func TestMocks_HostMatcher(t *testing.T) {
+func TestMocksHostMatcher(t *testing.T) {


🚫 [golangci] _{reported by reviewdog 🐶}
Function TestMocksHostMatcher missing the call to method parallel (paralleltest)

github-actions · 2023-10-04T15:29:49Z

mocks_test.go

@@ -150,7 +150,7 @@ func TestMocks_HostMatcher(t *testing.T) {
 	}
 }

-func TestMocks_HeaderMatcher(t *testing.T) {
+func TestMocksHeaderMatcher(t *testing.T) {


🚫 [golangci] _{reported by reviewdog 🐶}
Function TestMocksHeaderMatcher missing the call to method parallel (paralleltest)

github-actions · 2023-10-04T15:29:49Z

mocks_test.go

@@ -179,7 +179,7 @@ func TestMocks_HeaderMatcher(t *testing.T) {
 	}
 }

-func TestMocks_MockRequest_Header_WorksWithHeaders(t *testing.T) {
+func TestMocksMockRequestHeaderWorksWithHeaders(t *testing.T) {


🚫 [golangci] _{reported by reviewdog 🐶}
Function TestMocksMockRequestHeaderWorksWithHeaders missing the call to method parallel (paralleltest)

github-actions · 2023-10-04T15:31:00Z

mocks_test.go

@@ -193,7 +193,7 @@ func TestMocks_MockRequest_Header_WorksWithHeaders(t *testing.T) {
 	assert.Equal(t, true, matchError == nil)
 }

-func TestMocks_HeaderPresentMatcher(t *testing.T) {
+func TestMocksHeaderPresentMatcher(t *testing.T) {


🚫 [golangci] _{reported by reviewdog 🐶}
Function TestMocksHeaderPresentMatcher missing the call to method parallel (paralleltest)

github-actions · 2023-10-04T15:31:00Z

mocks_test.go

@@ -217,7 +217,7 @@ func TestMocks_HeaderPresentMatcher(t *testing.T) {
 	}
 }

-func TestMocks_HeaderNotPresentMatcher(t *testing.T) {
+func TestMocksHeaderNotPresentMatcher(t *testing.T) {


🚫 [golangci] _{reported by reviewdog 🐶}
Function TestMocksHeaderNotPresentMatcher missing the call to method parallel (paralleltest)

github-actions · 2023-10-04T15:31:00Z

mocks_test.go

@@ -241,7 +241,7 @@ func TestMocks_HeaderNotPresentMatcher(t *testing.T) {
 	}
 }

-func TestMocks_BasicAuth(t *testing.T) {
+func TestMocksBasicAuth(t *testing.T) {


🚫 [golangci] _{reported by reviewdog 🐶}
Function TestMocksBasicAuth missing the call to method parallel (paralleltest)

github-actions · 2023-10-04T15:31:00Z

mocks_test.go

@@ -292,9 +292,9 @@ func TestMocks_BasicAuth(t *testing.T) {
 	}
 }

-func TestMocks_QueryMatcher_Success(t *testing.T) {
+func TestMocksQueryMatcherSuccess(t *testing.T) {


🚫 [golangci] _{reported by reviewdog 🐶}
Function TestMocksQueryMatcherSuccess missing the call to method parallel (paralleltest)

github-actions · 2023-10-04T15:31:00Z

mocks_test.go

@@ -319,9 +319,9 @@ func TestMocks_QueryMatcher_Success(t *testing.T) {
 	}
 }

-func TestMocks_QueryMatcher_Errors(t *testing.T) {
+func TestMocksQueryMatcherErrors(t *testing.T) {


🚫 [golangci] _{reported by reviewdog 🐶}
Function TestMocksQueryMatcherErrors missing the call to method parallel (paralleltest)

github-actions · 2023-10-04T15:31:00Z

mocks_test.go

@@ -347,7 +347,7 @@ func TestMocks_QueryMatcher_Errors(t *testing.T) {
 	}
 }

-func TestMocks_QueryParams_DoesNotOverwriteQuery(t *testing.T) {
+func TestMocksQueryParamsDoesNotOverwriteQuery(t *testing.T) {


🚫 [golangci] _{reported by reviewdog 🐶}
Function TestMocksQueryParamsDoesNotOverwriteQuery missing the call to method parallel (paralleltest)

github-actions · 2023-10-04T15:31:00Z

mocks_test.go

@@ -360,7 +360,7 @@ func TestMocks_QueryParams_DoesNotOverwriteQuery(t *testing.T) {
 	assert.Equal(t, true, matchError == nil)
 }

-func TestMocks_QueryCollection(t *testing.T) {
+func TestMocksQueryCollection(t *testing.T) {


🚫 [golangci] _{reported by reviewdog 🐶}
Function TestMocksQueryCollection missing the call to method parallel (paralleltest)

github-actions · 2023-10-04T15:31:01Z

mocks_test.go

@@ -374,7 +374,7 @@ func TestMocks_QueryCollection(t *testing.T) {
 	assert.Equal(t, true, matchError == nil)
 }

-func TestMocks_QueryCollection_Fails(t *testing.T) {
+func TestMocksQueryCollectionFails(t *testing.T) {


🚫 [golangci] _{reported by reviewdog 🐶}
Function TestMocksQueryCollectionFails missing the call to method parallel (paralleltest)

github-actions · 2023-10-04T15:31:01Z

mocks_test.go

@@ -388,9 +388,9 @@ func TestMocks_QueryCollection_Fails(t *testing.T) {
 	assert.Equal(t, true, matchError != nil)
 }

-func TestMocks_QueryPresent(t *testing.T) {
+func TestMocksQueryPresent(t *testing.T) {


🚫 [golangci] _{reported by reviewdog 🐶}
Function TestMocksQueryPresent missing the call to method parallel (paralleltest)

github-actions · 2023-10-04T15:31:01Z

mocks_test.go

 			matchError := queryPresentMatcher(req, mockRequest)
 			assert.Equal(t, test.expectedError, matchError)
 		})
 	}
 }

-func TestMocks_QueryNotPresent(t *testing.T) {
+func TestMocksQueryNotPresent(t *testing.T) {


🚫 [golangci] _{reported by reviewdog 🐶}
Function TestMocksQueryNotPresent missing the call to method parallel (paralleltest)

github-actions · 2023-10-04T15:33:52Z

Code Metrics Report

	main (3e95163)	#7 (01b212b)	+/-
Coverage	82.4%	82.4%	+0.0%
Test Execution Time	7s	4s	-3s

Details

  |                     | main (3e95163) | #7 (01b212b) |  +/-  |
  |---------------------|----------------|--------------|-------|
+ | Coverage            |          82.4% |        82.4% | +0.0% |
  |   Files             |              7 |            7 |     0 |
  |   Lines             |           1586 |         1588 |    +2 |
+ |   Covered           |           1307 |         1309 |    +2 |
+ | Test Execution Time |             7s |           4s |   -3s |

Code coverage of files in pull request scope (77.8% → 82.4%)

Files	Coverage	+/-
assert.go	22.4%	0.0%
cookies.go	100.0%	0.0%
diagram.go	62.8%	0.0%
difflib/difflib.go	91.0%	0.0%
mocks.go	86.3%	0.0%
report.go	100.0%	0.0%
spectest.go	93.5%	+93.5%

Reported by octocov

github-actions · 2023-10-04T15:33:58Z

spectest_test.go

@@ -451,7 +450,7 @@ func TestApiTest_AddsTimedOutContextToRequest(t *testing.T) {
 		End()
 }

-func TestApiTest_AddsCancelledContextToRequest(t *testing.T) {
+func TestApiTestAddsCancelledContextToRequest(t *testing.T) {


🚫 [golangci] _{reported by reviewdog 🐶}
unnecessary leading newline (whitespace)

github-actions · 2023-10-04T15:33:58Z

spectest.go

-			request:   copyHttpRequest(mockReq),
-			response:  copyHttpResponse(mockRes),
+			request:   copyHTTPRequest(mockReq),
+			response:  copyHTTPResponse(mockRes),


🚫 [golangci] _{reported by reviewdog 🐶}
response body must be closed (bodyclose)

spectest.go

nao1215 added 4 commits October 4, 2023 23:49

Convert apitest to spectest

f156002

Fix linter

d189d2a

Update

663b1dd

Fix testcase name

c0c3c08

github-actions bot reviewed Oct 4, 2023

View reviewed changes

Fix typo

f37915d

github-actions bot reviewed Oct 4, 2023

View reviewed changes

nao1215 added 2 commits October 5, 2023 00:32

unused paralleltest

8855e91

Fix linter

a57956a

github-actions bot reviewed Oct 4, 2023

View reviewed changes

nao1215 merged commit bbffcbf into main Oct 4, 2023
9 of 10 checks passed

nao1215 deleted the do-simple branch October 9, 2023 13:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do simple #7

Do simple #7

nao1215 commented Oct 4, 2023

github-actions bot left a comment

github-actions bot Oct 4, 2023

github-actions bot Oct 4, 2023

github-actions bot Oct 4, 2023

github-actions bot Oct 4, 2023

github-actions bot Oct 4, 2023

github-actions bot Oct 4, 2023

github-actions bot Oct 4, 2023

github-actions bot Oct 4, 2023

github-actions bot Oct 4, 2023

github-actions bot Oct 4, 2023

github-actions bot Oct 4, 2023

github-actions bot Oct 4, 2023

github-actions bot Oct 4, 2023

github-actions bot Oct 4, 2023

github-actions bot Oct 4, 2023

github-actions bot Oct 4, 2023

github-actions bot Oct 4, 2023

github-actions bot Oct 4, 2023

github-actions bot Oct 4, 2023

github-actions bot Oct 4, 2023

github-actions bot commented Oct 4, 2023

github-actions bot Oct 4, 2023

github-actions bot Oct 4, 2023

Do simple #7

Do simple #7

Conversation

nao1215 commented Oct 4, 2023

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Oct 4, 2023

Choose a reason for hiding this comment

github-actions bot Oct 4, 2023

Choose a reason for hiding this comment

github-actions bot Oct 4, 2023

Choose a reason for hiding this comment

github-actions bot Oct 4, 2023

Choose a reason for hiding this comment

github-actions bot Oct 4, 2023

Choose a reason for hiding this comment

github-actions bot Oct 4, 2023

Choose a reason for hiding this comment

github-actions bot Oct 4, 2023

Choose a reason for hiding this comment

github-actions bot Oct 4, 2023

Choose a reason for hiding this comment

github-actions bot Oct 4, 2023

Choose a reason for hiding this comment

github-actions bot Oct 4, 2023

Choose a reason for hiding this comment

github-actions bot Oct 4, 2023

Choose a reason for hiding this comment

github-actions bot Oct 4, 2023

Choose a reason for hiding this comment

github-actions bot Oct 4, 2023

Choose a reason for hiding this comment

github-actions bot Oct 4, 2023

Choose a reason for hiding this comment

github-actions bot Oct 4, 2023

Choose a reason for hiding this comment

github-actions bot Oct 4, 2023

Choose a reason for hiding this comment

github-actions bot Oct 4, 2023

Choose a reason for hiding this comment

github-actions bot Oct 4, 2023

Choose a reason for hiding this comment

github-actions bot Oct 4, 2023

Choose a reason for hiding this comment

github-actions bot Oct 4, 2023

Choose a reason for hiding this comment

github-actions bot commented Oct 4, 2023

Code Metrics Report

Code coverage of files in pull request scope (77.8% → 82.4%)

github-actions bot Oct 4, 2023

Choose a reason for hiding this comment

github-actions bot Oct 4, 2023

Choose a reason for hiding this comment