Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore comments in blocks of code #146

Closed
tapia opened this issue Feb 21, 2020 · 1 comment
Closed

Ignore comments in blocks of code #146

tapia opened this issue Feb 21, 2020 · 1 comment
Labels
new-feature Indecates new feature which maintainer planning or under consideration
Projects
Progress management

Comments

@tapia
Copy link

tapia commented Feb 21, 2020

If you write some markdown like this:

```python
# some comment
```

The comment is correctly ignored. But this is also valid markdown, and the comment is wrongly interpreted as a title:

~~~python
# some comment
~~~
@naokazuterada naokazuterada added the new-feature Indecates new feature which maintainer planning or under consideration label Feb 22, 2020
@naokazuterada naokazuterada added this to work in progress in Progress management Feb 22, 2020
naokazuterada added a commit that referenced this issue Feb 23, 2020
@naokazuterada
Support code block with ~~~ pattern #146
abbf34e
naokazuterada added a commit that referenced this issue Feb 23, 2020
@naokazuterada
Merge branch 'add-codeblock-type'
49b7cd0 
* add-codeblock-type:
  Add message for 4.0.1
  Add test for ~~~ code block
  Support code block with ~~~ pattern #146
  Fix tests
@naokazuterada
Copy link
Owner

This problem should be fixed in 4.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new-feature Indecates new feature which maintainer planning or under consideration
Projects
Progress management
work in progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@naokazuterada @tapia