Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught (in promise) Error: Unsupported file type #80

Closed
chrisbraddock opened this issue Sep 4, 2017 · 2 comments
Closed

Uncaught (in promise) Error: Unsupported file type #80

chrisbraddock opened this issue Sep 4, 2017 · 2 comments
Labels

Comments

@chrisbraddock
Copy link

Hey - I ran in to an uncaught issue where someone has sent me a WMA file I've tried to throw through waveform-playlist:

Imgur

You can see the issue by dragging any unsupported file (e.g. a .txt file even works) in your Working With Local Files example.

I was able to catch it by throwing a .catch in Playlist.js at ee.on('newtrack'... after this.load but I'm not sure what the right behavior would really be here.

If you can provide some direction I can attempt a pull request.

Any thoughts?

@naomiaro
Copy link
Owner

naomiaro commented Sep 5, 2017

Hey thanks for this! This was probably always an issue, but I think just recently there was changes to how unhandled errors in promises were dealt with in browsers. I'm not quite sure of the best way to handle this right now, I'll have to check it out.

It could work to just silently catch the error and then not continue with that file, but there should be a way really if someone is using the ee themselves that they can get access to any errors that occurred here due to file type.

@chrisbraddock
Copy link
Author

Thanks for the quick response. I definitely vote for exposing the error. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants