[iOS] Fix issue when paymentToken is not present on real iOS device.
#37
+42
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other changes: - this commit unifies responses for iOS simulator and real iOS device - `serializedPaymentData` is no longer present. Data is always deserialised. - add some Flow types and fix some (e.g `object` -> `Object`)
Andreyco
changed the title
paymentToken is not present on real iOS device.paymentToken is not present on real iOS device.
naoufal
reviewed
Oct 31, 2017
| @@ -54,6 +54,18 @@ import { | |||
| SUPPORTED_METHOD_NAME | |||
| } from './constants'; | |||
|
|
|||
| type PaymentDetailsIOS = { | |||
There was a problem hiding this comment.
👍 Good call
Let's move these to the already existing types.js file.
| const { | ||
| paymentData: serializedPaymentData, |
There was a problem hiding this comment.
Let's not refer to serializedPaymentData as paymentData even if we'll have a type for it -- It's likely to stump developers not using flow.
There was a problem hiding this comment.
Not sure I understand your advice here... Could you elaborate?
|
|
||
| return { | ||
| paymentData: isSimulator ? null : JSON.parse(serializedPaymentData), |
There was a problem hiding this comment.
I could see this stumping some people. Could you update the README to warn users of the behaviour in TEST.
There was a problem hiding this comment.
Sure, documentation is improved.
|
Sorry for being unresponsive in past days. Will take a look at those during this weekend. Appreciate your time here. |
…n device vs simulator
…uction and real device.
|
any word on this pr? |
Closed
riso
pushed a commit
to smarkets/react-native-payments
that referenced
this pull request
Aug 15, 2019
naoufal#37) * Fix issue when `paymentToken` is not present on real iOS device. Other changes: - this commit unifies responses for iOS simulator and real iOS device - `serializedPaymentData` is no longer present. Data is always deserialised. - add some Flow types and fix some (e.g `object` -> `Object`) * Move type definition into dedicated file. * [Docs] Mention `paymentData` inconsistencies when running Apple Pay on device vs simulator * [Docs] Add `Testing Payments` section and advise user to test in production and real device.
tprata
pushed a commit
to tprata/react-native-payments
that referenced
this pull request
Nov 23, 2019
naoufal#37) * Fix issue when `paymentToken` is not present on real iOS device. Other changes: - this commit unifies responses for iOS simulator and real iOS device - `serializedPaymentData` is no longer present. Data is always deserialised. - add some Flow types and fix some (e.g `object` -> `Object`) * Move type definition into dedicated file. * [Docs] Mention `paymentData` inconsistencies when running Apple Pay on device vs simulator * [Docs] Add `Testing Payments` section and advise user to test in production and real device.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other changes:
serializedPaymentDatais no longer present. Data is always deserialised.object->Object)Fixes #30