replace deprecated RCTEventDispatcher #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koenpunt
force-pushed
the
eventemitter
branch
from
6e071a0
to
0752228
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To not break the public API I've mapped theadd/removeEventListenertoNativeEventEmitter'saddListener, instead of returning the subscription; this is a common pattern that can be found also in the React Native core (e.g.: https://github.com/facebook/react-native/blob/1e8f3b11027fe0a7514b4fc97d0798d3c64bc895/Libraries/Network/NetInfo.js#L210)My previous comment was not completely valid; NativeEventEmitter also implements a
removeListenermethod, so no need to keep track of the listeners ourselves. Still unclear why they use that pattern in theNetInfomodule tho..