Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LLDP Neighbor update #40

Merged
merged 3 commits into from Mar 1, 2017
Merged

LLDP Neighbor update #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f6fa6f
Test for interfaces with no lldp neighbor
itdependsnetworks Feb 27, 2017
a012f40
Add expected input
itdependsnetworks Feb 27, 2017
f4a2fe1
Add expected output
itdependsnetworks Feb 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions napalm_panos/panos.py
View file
Open in desktop
Expand Up @@ -398,8 +398,10 @@ def get_lldp_neighbors(self):

if local_int not in neighbors.keys():
neighbors[local_int] = []

lldp_neighs = lldp_item['neighbors']['entry']
try:
lldp_neighs = lldp_item.get('neighbors').get('entry')
except AttributeError:
lldp_neighs = ''
if isinstance(lldp_neighs, dict):
lldp_neighs = [lldp_neighs]

Expand Down
18 changes: 18 additions & 0 deletions ...t_get_lldp_neighbors/no_neighbor/_show__lldp__neighbors_all__neighbors___lldp___show_.xml
View file
Open in desktop
@@ -0,0 +1,18 @@
<response status="success">
<result>
<entry name="ethernet1/1">
<local>
<index>16</index>
<port-id>1</port-id>
</local>
<neighbors></neighbors>
</entry>
<entry name="ethernet1/2">
<local>
<index>17</index>
<port-id>2</port-id>
</local>
<neighbors></neighbors>
</entry>
</result>
</response>
1 change: 1 addition & 0 deletions test/unit/mocked_data/test_get_lldp_neighbors/no_neighbor/expected_result.json
View file
Open in desktop
@@ -0,0 +1 @@
{"ethernet1/1": [], "ethernet1/2": []}