Set & delete users template

[mirceaulinic]

No description provided.

[coveralls]

Coverage remained the same at 79.587% when pulling bb95552 on mirceaulinic:USERS-TPL into 3aee29e on napalm-automation:develop.

[coveralls]

Coverage remained the same at 79.587% when pulling bb95552 on mirceaulinic:USERS-TPL into 3aee29e on napalm-automation:develop.

[itdependsnetworks]

At least when using ansible's implementation of jinja, it will fail if the key doesn't exist. I would suggest the following:

{%- for user_name, user_details in users.items() %}
{%- if user_details.get('password') %}
username {{ user_name }} secret 5 {{ user_details.password }}
{%- else %}
username {{ user_name }} nopassword
{%- endif %}
{%- if user_details.get('level') %}
username {{ user_name }} privilege {{ user_details.level }}
{%- endif %}
{%- if user_details.get('sshkeys') %}
{%- for sshkey in user_details.sshkeys %}
username {{ user_name }} sshkey {{ sshkey }}
{%- endfor %}
{%- endif %}
{%- endfor %}

[dbarrosop]

I agree with @itdependsnetworks. We should check the variables are present before trying to configure them. Newest EOS release support users without password, only with keys. And there might be people using passwords only instead of keys.

[dbarrosop]

Isn't it enough to do something like:

{%- for user_name, user_details in users_to_delete %}
default username {{ user_name}}
{%- endfor %}

[mirceaulinic]

What does:

default username {{ user_name}}

do more specifically?

[mirceaulinic]

We should check the variables are present before trying to configure them. Newest EOS release support users without password, only with keys. And there might be people using passwords only instead of keys.

Can't agree more - that's why I have:

{%- if user_details.sshkeys %}

Which works in pure python.. but it seems to fail in other obscure implementations.

But I agree on the additional level of safety.

[coveralls]

Coverage remained the same at 79.587% when pulling 3a40477 on mirceaulinic:USERS-TPL into 3aee29e on napalm-automation:develop.

[coveralls]

Coverage remained the same at 79.587% when pulling 3a40477 on mirceaulinic:USERS-TPL into 3aee29e on napalm-automation:develop.

[coveralls]

Coverage remained the same at 79.587% when pulling 3a40477 on mirceaulinic:USERS-TPL into 3aee29e on napalm-automation:develop.