Skip to content
This repository has been archived by the owner on Feb 10, 2018. It is now read-only.

Detect the format of the config and try loading it #132

Merged
merged 2 commits into from
Mar 26, 2017
Merged

Detect the format of the config and try loading it #132

merged 2 commits into from
Mar 26, 2017

Conversation

mirceaulinic
Copy link
Member

No description provided.

@mirceaulinic mirceaulinic added this to the 0.7.0 milestone Mar 15, 2017
@mirceaulinic
Copy link
Member Author

@dbarrosop @ktbyers I made some tests, this seems to work fine. Please let me know your suggestions / improvements etc.

@coveralls
Copy link

coveralls commented Mar 15, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-1.4%) to 83.883% when pulling a563339 on mirceaulinic:cfg-fmt into 26c628b on napalm-automation:develop.

@mirceaulinic mirceaulinic mentioned this pull request Mar 15, 2017
Merged
@dbarrosop
Copy link
Member

Could you add tests? I think this is one of those methods that deserves it :) Other than that LGTM!

@mirceaulinic mirceaulinic modified the milestones: 0.10.0, 0.7.0 Mar 23, 2017
@dbarrosop dbarrosop merged commit f67ad16 into napalm-automation:develop Mar 26, 2017
mirceaulinic added a commit that referenced this pull request Mar 29, 2017
@mirceaulinic
Jumping several releases
47e2da2 
Because there will be some backwards incompatible changes
when fixing #139,
#138
and adding the new configuration format autodetect feature from
#132.
@zachmoody zachmoody mentioned this pull request May 3, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ktbyers ktbyers Awaiting requested review from ktbyers

@dbarrosop dbarrosop Awaiting requested review from dbarrosop

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mirceaulinic @coveralls @dbarrosop