add get_config #52
add get_config #52
Conversation
|
|
||
| # no get_cmd means it should mock the eznc get_config | ||
| else: | ||
| filename = 'get_config-' + options['database'] |
There was a problem hiding this comment.
Can you please insert all the options in the filename please?
e.g.:
'__'.join(['{0}_{1}'.format(k,v) for k,v in options.items()])Eventually we can include also the filter at some point.
|
|
||
| # no get_cmd means it should mock the eznc get_config | ||
| else: | ||
| filename = 'get_config-' + options['database'] |
| } | ||
|
|
||
| if retrieve in ('candidate', 'all'): | ||
| config = self.device.rpc.get_config(filter_xml=None, options=options) |
There was a problem hiding this comment.
The candidate config would make sense if the user is in edit more - otherwise I think it should be empty.
You can introduce a new flag to check that, e.g.: pending_changes https://github.com/napalm-automation/napalm-iosxr/blob/develop/napalm_iosxr/iosxr.py that must be set in _load_candidate, commit_config and discard_config
There was a problem hiding this comment.
I don't agree with that, if I call get_config(retrieve='candidate') I'd expect something back and not an empty string. Happy to do it if that's what you guys have decided.
There was a problem hiding this comment.
By definition the candidate config is only when in edit mode. It is equally true that the candidate config can be shared across multiple sessions, not limited to the current session only. So yes, I think your point makes sense to not restrict the gathering of the candidate config.
|
failed on |
|
@grizz, that's not the error. However, In any case, the error is this: |
|
@grizz this is the error traceback: ===================================================
ERROR: test_traceroute (TestJunOSDriver.TestGetterJunOSDriver)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/travis/virtualenv/python2.7.9/src/napalm-base/napalm_base/test/base.py", line 457, in test_traceroute
get_traceroute = self.device.traceroute(destination)
File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/napalm_junos/junos.py", line 1198, in traceroute
rpc_reply = self.device._conn.rpc(traceroute_rpc)._NCElement__doc
File "/home/travis/build/napalm-automation/napalm-junos/test/unit/TestJunOSDriver.py", line 162, in response
rpc_reply = RPCReply(self._rpc.get_config(get_cmd=non_std_command))
File "/home/travis/build/napalm-automation/napalm-junos/test/unit/TestJunOSDriver.py", line 137, in get_config
filename = 'get_config-' + options['database']
KeyError: 'database'Fails in the traceroute method which does not send any options dictionary which is just a hack to reuse some of the existing code. Just make sure to include all the options in the filename. |
|
Ahh right, not sure how I missed the traceback, will be fixed with the file rename. And yes, in that case if get_cmd is correct because by default it's an empty str. |
No description provided.