Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding buffer interface to prevent spurious messages #268

Merged
merged 7 commits into from
Sep 25, 2018
Merged

Adding buffer interface to prevent spurious messages #268

merged 7 commits into from
Sep 25, 2018

Conversation

mirceaulinic
Copy link
Member

Closes #244 - see issue for further details.

@mirceaulinic mirceaulinic added this to the 0.7.0 milestone Aug 28, 2018
@mirceaulinic mirceaulinic self-assigned this Aug 28, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 42.991% when pulling f9a1fa5 on buffer-cache into 0aad65b on develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 42.991% when pulling f9a1fa5 on buffer-cache into 0aad65b on develop.

@coveralls
Copy link

coveralls commented Aug 28, 2018 •
edited

Coverage Status

Coverage decreased (-0.1%) to 42.991% when pulling 00f4db6 on buffer-cache into 0aad65b on develop.

@mirceaulinic
Ad dependency note
b1ae9fb
@mirceaulinic
Include the host name into the encoded message key
00f4db6 
This ensures that two messages with similar content from different devices
wouldn't overlap, e.g., when two devices complain about the same NTP server as
unreachable, we should have two separate messages.
@mirceaulinic mirceaulinic merged commit a700132 into develop Sep 25, 2018
@mirceaulinic mirceaulinic deleted the buffer-cache branch September 25, 2018 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luke-orden luke-orden luke-orden approved these changes

Assignees

@mirceaulinic mirceaulinic

Labels
buffer core feature
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mirceaulinic @coveralls @luke-orden