Expose publish metrics with more attrbutes #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding another metrics ``napalm_logs_device_published_messages_attrs`` besides the existing ``napalm_logs_device_published_messages`` to publish metrics with more attributes. As this may potentially generate a large amount of metrics I opted not to replace the existing one, and rather have it separately, and with the possibility to disable it in case it causes troubles.
luke-orden
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding another metrics
napalm_logs_device_published_messages_attrsbesides the existing
napalm_logs_device_published_messagestopublish metrics with more attributes. As this may potentially generate
a large amount of metrics I opted not to replace the existing one, and
rather have it separately, and with the possibility to disable it in
case it causes troubles.