Remove previous_state and current_state labels from the BGP metrics #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a second thought, having these two labels for ``napalm_logs_bgp_neighbor_state_changed_total`` seems a bit overzealous and perhaps pointless, as it's probably more useful to prompt on ``changes()`` or something similar.
|
Merging right now, but open to discussion and more thoughts whether this makes sense indeed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a second thought, having these two labels for
napalm_logs_bgp_neighbor_state_changed_totalseems a bit overzealousand perhaps pointless, as it's probably more useful to prompt on
changes()or something similar.